DevTools: get rid of WebInspector.cssModel, use target models instead

DevTools: get rid of WebInspector.cssModel, use target models instead

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178405

[pfeldman, 2014-07-16 19:57:58]

https://codereview.chromium.org/396993003/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/Tests.js (right):

https://codereview.chromium.org/396993003/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/Tests.js:500: if
(WebInspector.consoleModel.messages().length === 1)
I'll have to modify this since consoleModel is not available in browsertests
runner.

[sergeyv, 2014-07-16 20:50:29]

As a drive by of this change we can fix two issues of WebInspector.console:
1. We never clear messages from WebInspector.console. It was done intentionally.
There were just a few calls of WebInspector.console and no obvious signal that
it should be cleared, it was decided that this behavior is not critical flaw. 

2.  Messages from WebInspector.console are missed in
WebInspector.Main.WarningErrorCounter and in PresentationConsoleHelper as well,
but I'm sure that last one is unimportant in this case.  It wasn't done
intentionally, it is a just bug. 

Looks like both of those issues can be fixed in multitargetConsoleModel: 
we can clear WebInspector.console simultaneously  with multitargetConsoleModel
and send messages of WebInspector.console through multitargetConsoleModel too,
but it requires same interface for messages from consoleModels and
WebInspector.console

https://codereview.chromium.org/396993003/diff/1/Source/devtools/front_end/Te...
File Source/devtools/front_end/Tests.js (right):

https://codereview.chromium.org/396993003/diff/1/Source/devtools/front_end/Te...
Source/devtools/front_end/Tests.js:500: if
(WebInspector.consoleModel.messages().length === 1)
Looks like it should fail since we do not have WebInspector.consoleModel, either
it should be initialized in InspectorFrontendAPI.loadCompleted, either it should
be replaced with WebInspector.multitargetConsoleModel

[sergeyv, 2014-07-17 10:49:39]

lgtm

[pfeldman, 2014-07-17 10:54:29]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-17 10:55:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/396993003/20001

[commit-bot: I haz the power, 2014-07-17 12:09:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/15905)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17456)

[commit-bot: I haz the power, 2014-07-17 12:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 12:33:58]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[pfeldman, 2014-07-17 17:38:41]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:39:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/396993003/40001

[commit-bot: I haz the power, 2014-07-17 17:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 17:40:03]

Failed to apply patch for LayoutTests/inspector/layers/tracing-layer-tree.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/inspector/layers/tracing-layer-tree.html
  Hunk #1 FAILED at 27.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/inspector/layers/tracing-layer-tree.html.rej

Patch:       LayoutTests/inspector/layers/tracing-layer-tree.html
Index: LayoutTests/inspector/layers/tracing-layer-tree.html
diff --git a/LayoutTests/inspector/layers/tracing-layer-tree.html
b/LayoutTests/inspector/layers/tracing-layer-tree.html
index
60c94d3f968f85bde7a0b377413d1586d704665c..ba89013e844feb788c49823ebca2a093d938031f
100644
--- a/LayoutTests/inspector/layers/tracing-layer-tree.html
+++ b/LayoutTests/inspector/layers/tracing-layer-tree.html
@@ -27,7 +27,7 @@ function test()
 {
    
InspectorTest.invokeWithTracing(WebInspector.TracingTimelineModel.defaultTracingCategoryFilter,
"doActions", onTracingComplete);
 
-    var target = /** @type {!WebInspector.Target} */
(WebInspector.targetManager.activeTarget());
+    var target = /** @type {!WebInspector.Target} */
(WebInspector.targetManager.mainTarget());
     var layerTree = new WebInspector.TracingLayerTree(target);
 
     function onTracingComplete()

[pfeldman, 2014-07-17 20:01:26]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-17 20:02:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/396993003/60001

[commit-bot: I haz the power, 2014-07-17 21:10:44]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/15997)

[commit-bot: I haz the power, 2014-07-17 21:34:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 21:34:25]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[pfeldman, 2014-07-17 21:40:13]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-07-17 21:41:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/396993003/80001

[commit-bot: I haz the power, 2014-07-17 23:27:09]

Change committed as 178405