Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3637)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 396973002: Password bubble: Don't focus by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment + test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index f8f08d6fbd6dae7c821836692877af401d427336..356919e43c008c9ec0c899d2b20ca244aa3204db 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -434,6 +434,11 @@ ManagePasswordsBubbleView* ManagePasswordsBubbleView::manage_passwords_bubble_ =
NULL;
// static
+const ManagePasswordsBubbleView* ManagePasswordsBubbleView::Bubble() {
+ return ManagePasswordsBubbleView::manage_passwords_bubble_;
+}
+
+// static
void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
DisplayReason reason) {
Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
@@ -467,6 +472,12 @@ void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
}
manage_passwords_bubble_->GetWidget()->Show();
manage_passwords_bubble_->SetArrowPaintType(views::BubbleBorder::PAINT_NONE);
+ // set_use_focusless(true) has adverse effect on Windows.
+ // 1) The bubble can't be the active window (which is not desired behavior).
+ // 2) The bubble doesn't get WM_LBUTTONDOWN event. Therefore, all the buttons
+ // get stuck.
+ // TODO(vasilii): remove this line once the bug in infrastructure is resolved.
+ manage_passwords_bubble_->set_use_focusless(false);
}
// static
@@ -494,7 +505,8 @@ ManagePasswordsBubbleView::ManagePasswordsBubbleView(
never_save_passwords_(false) {
// Compensate for built-in vertical padding in the anchor view's image.
set_anchor_view_insets(gfx::Insets(2, 0, 2, 0));
- set_notify_enter_exit_on_child(true);
+ // Don't focus by default.
+ set_use_focusless(true);
if (anchor_view)
anchor_view->SetActive(true);
}

Powered by Google App Engine
This is Rietveld 408576698