LayoutTests/http/tests/serviceworker/chromium/resources/resolve-after-window-close.html - Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/chromium/resources/resolve-after-window-close.html

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remake (add WebType::dispose()) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/resources/empty-worker.js ('k') | Source/bindings/core/v8/CallbackPromiseAdapter.h » ('j') | Source/bindings/core/v8/CallbackPromiseAdapter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/chromium/resources/resolve-after-window-close.html

diff --git a/LayoutTests/http/tests/serviceworker/resources/window-close-during-registration.html b/LayoutTests/http/tests/serviceworker/chromium/resources/resolve-after-window-close.html

similarity index 68%

copy from LayoutTests/http/tests/serviceworker/resources/window-close-during-registration.html

copy to LayoutTests/http/tests/serviceworker/chromium/resources/resolve-after-window-close.html

index 069ea0ec9bb62669f62f5af524830c8431a3c351..7614c62b093a981b00de0163c2b571499aa850f3 100644

--- a/LayoutTests/http/tests/serviceworker/resources/window-close-during-registration.html

+++ b/LayoutTests/http/tests/serviceworker/chromium/resources/resolve-after-window-close.html

@@ -6,10 +6,6 @@ navigator.serviceWorker.unregister(scope).then(function() {

var promise = navigator.serviceWorker.register('empty-worker.js', { scope: scope });

window.close();

window.opener.done();

- return promise;

-}).catch(function(error) {

- window.opener.testFailed(error.message);

- window.opener.done();

});

</script>

</html>