Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerContainer.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
index 1b314266d3baaa47107bdabbe00ef766cff9dbe6..b2cbfdf13d4a070c480c6330f2386fcac0f6896d 100644
--- a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
@@ -130,7 +130,6 @@ ScriptPromise ServiceWorkerContainer::registerServiceWorker(ScriptState* scriptS
class UndefinedValue {
public:
-
#ifdef DISABLE_SERVICE_WORKER_REGISTRATION
typedef WebServiceWorker WebType;
#else
@@ -141,6 +140,10 @@ public:
ASSERT(!registration); // Anything passed here will be leaked.
return V8UndefinedType();
}
+ static void dispose(WebServiceWorker* worker)
+ {
+ ASSERT(!worker); // Anything passed here will be leaked.
+ }
private:
UndefinedValue();
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698