Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: Source/modules/push_messaging/PushRegistration.h

Issue 396963002: ServiceWorker: Bypass resolving a promise when ExecutionContext is gone (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/push_messaging/PushRegistration.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/push_messaging/PushRegistration.h
diff --git a/Source/modules/push_messaging/PushRegistration.h b/Source/modules/push_messaging/PushRegistration.h
index b3865ee852a97cb5f06c12596ac8858c13449bfe..c3e515c60979c5d51c2dd57e21e58f7b15475261 100644
--- a/Source/modules/push_messaging/PushRegistration.h
+++ b/Source/modules/push_messaging/PushRegistration.h
@@ -8,7 +8,6 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "platform/heap/Handle.h"
#include "public/platform/WebPushRegistration.h"
-#include "wtf/OwnPtr.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -19,11 +18,8 @@ class PushRegistration FINAL : public GarbageCollectedFinalized<PushRegistration
public:
// For CallbackPromiseAdapter.
typedef blink::WebPushRegistration WebType;
- static PushRegistration* from(ScriptPromiseResolver*, WebType* registrationRaw)
- {
- OwnPtr<WebType> registration = adoptPtr(registrationRaw);
- return new PushRegistration(registration->endpoint, registration->registrationId);
- }
+ static PushRegistration* from(ScriptPromiseResolver*, WebType* registrationRaw);
+ static void dispose(WebType* registrationRaw);
virtual ~PushRegistration();
« no previous file with comments | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/push_messaging/PushRegistration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698