Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 396933002: Remove extensions_manifest_types extensions API on Android. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove extensions_manifest_types extensions API on Android. BUG=305852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/extensions/installed_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/api.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
M extensions/renderer/messaging_bindings.cc View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-16 17:47:57 UTC) #1
Yoyo Zhou
LGTM, but this CL description seems incomplete. Should it say something about Android?
6 years, 5 months ago (2014-07-16 18:53:39 UTC) #2
Lei Zhang
On 2014/07/16 18:53:39, Yoyo Zhou wrote: > LGTM, but this CL description seems incomplete. Should ...
6 years, 5 months ago (2014-07-16 19:14:41 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-16 19:14:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/396933002/1
6 years, 5 months ago (2014-07-16 19:16:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 20:40:05 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 23:28:43 UTC) #7
Message was sent while issue was closed.
Change committed as 283575

Powered by Google App Engine
This is Rietveld 408576698