Reduce amount of boilerplate in assert-scope.h

Reduce amount of boilerplate in assert-scope.h

R=vogelheim@chromium.org

[vogelheim, 2014-07-16 09:29:57]

lgtm

This does reduce boilerplate, but honestly I'm not sure whether it's really an
improvement. This is way deep in 'bikeshed' territory, so please decide as you
see fit.


My concern is this: When you recently used one of these asserts, I spent quite a
bit of time reading through the code review to figure out /how/ this actually
worked. But at least on the logic was plain C++, so I could work my way through
it. I'm fairly certain that - in this newer version, with the macro soup and all
- I would have had to spent a lot more time on figuring it out.

A related but minor point is that I'm certain tools (code searching,
refactoring, etc.) will have a hard time with this. (It's a minor point since we
don't use a whole lot of those.)

[Yang, 2014-07-16 09:31:51]

On 2014/07/16 09:29:57, vogelheim wrote:
> lgtm
> 
> This does reduce boilerplate, but honestly I'm not sure whether it's really an
> improvement. This is way deep in 'bikeshed' territory, so please decide as you
> see fit.
> 
> 
> My concern is this: When you recently used one of these asserts, I spent quite
a
> bit of time reading through the code review to figure out /how/ this actually
> worked. But at least on the logic was plain C++, so I could work my way
through
> it. I'm fairly certain that - in this newer version, with the macro soup and
all
> - I would have had to spent a lot more time on figuring it out.
> 
> A related but minor point is that I'm certain tools (code searching,
> refactoring, etc.) will have a hard time with this. (It's a minor point since
we
> don't use a whole lot of those.)

Yeah I agree to this to a certain extend. Then again, V8 is already using this
sort of macro magic all over the place. I'll get a second opinion.

[Yang, 2014-07-16 09:32:36]

Adding Jakob for a second opinion. TL;DR: Macro-ify assertion scopes to reduce
boilerplate?

[Jakob Kummerow, 2014-07-16 10:47:04]

I'm torn. Do as you please :-)

[Yang, 2014-07-16 11:27:51]

On 2014/07/16 10:47:04, Jakob wrote:
> I'm torn. Do as you please :-)

I'll drop this then.