Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 396863003: [Android] Always show infobars at the bottom of the screen. (Closed)

Created:
6 years, 5 months ago by newt (away)
Modified:
6 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Android] Always show infobars at the bottom of the screen. Previously, infobars were shown at the bottom of the screen on phones, but at the top of the screen on tablets. BUG=375379 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283593

Patch Set 1 #

Patch Set 2 : added back areInfoBarsOnTop to prevent downstream breakage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -75 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AnimationHelper.java View 4 chunks +14 lines, -30 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/ContentWrapperView.java View 3 chunks +2 lines, -19 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java View 1 7 chunks +4 lines, -24 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
newt (away)
PTAL
6 years, 5 months ago (2014-07-16 02:27:26 UTC) #1
gone
Code cleans up nicely when you don't have to account for weird things. lgtm.
6 years, 5 months ago (2014-07-16 16:45:10 UTC) #2
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 5 months ago (2014-07-16 18:55:25 UTC) #3
newt (away)
On 2014/07/16 16:45:10, dfalcantara wrote: > Code cleans up nicely when you don't have to ...
6 years, 5 months ago (2014-07-16 18:55:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/396863003/1
6 years, 5 months ago (2014-07-16 18:57:33 UTC) #5
newt (away)
The CQ bit was unchecked by newt@chromium.org
6 years, 5 months ago (2014-07-16 23:50:01 UTC) #6
newt (away)
The CQ bit was checked by newt@chromium.org
6 years, 5 months ago (2014-07-17 00:14:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/396863003/20001
6 years, 5 months ago (2014-07-17 00:17:26 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 00:26:55 UTC) #9
Message was sent while issue was closed.
Change committed as 283593

Powered by Google App Engine
This is Rietveld 408576698