Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 396843002: [Android] Fix BookmarksBridge::GetAllBookmarkIDsOrderedByCreationDate . (Closed)

Created:
6 years, 5 months ago by Kibeom Kim (inactive)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, newt (away), Ted C, Ian Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix BookmarksBridge::GetAllBookmarkIDsOrderedByCreationDate. GetAllBookmarkIDsOrderedByCreationDate had a place where it incorrectly terminated itself (return) while reading the bookmarks. BUG=386785 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283493

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Kibeom Kim (inactive)
6 years, 5 months ago (2014-07-16 00:02:13 UTC) #1
newt (away)
lgtm
6 years, 5 months ago (2014-07-16 00:22:42 UTC) #2
David Trainor- moved to gerrit
lgtm
6 years, 5 months ago (2014-07-16 07:49:10 UTC) #3
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 5 months ago (2014-07-16 08:08:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/396843002/1
6 years, 5 months ago (2014-07-16 08:10:53 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 12:25:10 UTC) #6
Kibeom Kim (inactive)
The CQ bit was unchecked by kkimlabs@chromium.org
6 years, 5 months ago (2014-07-16 18:35:08 UTC) #7
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 5 months ago (2014-07-16 18:35:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/396843002/1
6 years, 5 months ago (2014-07-16 18:41:28 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 20:41:57 UTC) #10
Message was sent while issue was closed. 
Change committed as 283493

Powered by Google App Engine
This is Rietveld 408576698