Move Start/StopTest to Run() instead.

Move Start/StopTest to Run() instead.

The previous location of Start/StopTest isn't correct because it does
not encompass all calls to
AddSkip/AddSuccess/AddFailure/etc. Unfortunately, the new location 
means that test with discard_first_result will still execute
StartTest/StopTest. I think this is fine.

Also add Start/StopTest around the check for test.CanRunForPage(page)
for the same reason.

BUG=392901
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283708

[chrishenry, 2014-07-15 23:56:26]

Another alternative for CanRunForPage would be to move that check to within
_PrepareAndRunPage, probably not necessary tho.

[dtu, 2014-07-16 00:04:59]

https://codereview.chromium.org/396833002/diff/10002/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/396833002/diff/10002/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_runner.py:420: test.StopTest(page)
try:
  # Run
finally:
  test.StopTest(page)

[chrishenry, 2014-07-16 00:27:25]

https://codereview.chromium.org/396833002/diff/10002/tools/telemetry/telemetr...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/396833002/diff/10002/tools/telemetry/telemetr...
tools/telemetry/telemetry/page/page_runner.py:420: test.StopTest(page)
On 2014/07/16 00:04:58, dtu wrote:
> try:
>   # Run
> finally:
>   test.StopTest(page)

Done.

[dtu, 2014-07-16 00:44:12]

lgtm

[chrishenry, 2014-07-16 00:55:14]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-07-16 01:00:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/396833002/30001

[commit-bot: I haz the power, 2014-07-16 07:46:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-16 07:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 07:59:37]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[chrishenry, 2014-07-16 14:28:48]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-07-16 14:31:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/396833002/50001

[chrishenry, 2014-07-16 23:50:52]

The CQ bit was unchecked by chrishenry@google.com

[chrishenry, 2014-07-16 23:50:56]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-07-16 23:53:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/396833002/50001

[commit-bot: I haz the power, 2014-07-17 08:17:59]

Change committed as 283708