Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 396813004: Make selection_owner.h not include Xlib.h for consistency. (Closed)

Created:
6 years, 5 months ago by pkotwicz
Modified:
6 years, 5 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, derat+watch_chromium.org, dcheng, yusukes+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make selection_owner.h not include Xlib.h for consistency with selection_requestor.h BUG=367549 TEST=None R=derat TBR=dcheng,sky (for trivial changes to clipboard_aurax11.cc and os_exchange_data_provider_aurax11.cc) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283825

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M ui/base/clipboard/clipboard_aurax11.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/x/selection_owner.h View 5 chunks +11 lines, -15 lines 0 comments Download
M ui/base/x/selection_owner.cc View 8 chunks +38 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
pkotwicz
derat@ PTAL. This CL is separate for the sake of keeping things clean. (The next ...
6 years, 5 months ago (2014-07-16 23:26:43 UTC) #1
Daniel Erat
lgtm thanks!
6 years, 5 months ago (2014-07-17 02:30:39 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 14:09:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/396813004/20001
6 years, 5 months ago (2014-07-17 14:10:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 15:14:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 15:15:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/171145) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/160186) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-17 15:15:52 UTC) #7
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 15:58:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/396813004/40001
6 years, 5 months ago (2014-07-17 15:59:52 UTC) #9
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 16:49:12 UTC) #10
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 16:49:48 UTC) #11
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 16:50:13 UTC) #12
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 5 months ago (2014-07-17 16:51:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/396813004/40001
6 years, 5 months ago (2014-07-17 16:53:08 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 18:42:10 UTC) #15
Message was sent while issue was closed.
Change committed as 283825

Powered by Google App Engine
This is Rietveld 408576698