Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 396813003: Hook up delegate interfaces so that athena can create its own WebContentsViewDelegate (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Hook up delegate interfaces so that athena can create its own WebContentsViewDelegate This is necessary to handle context menu , popup menu etc. BUG=380438 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283839

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M apps/shell/app/shell_main_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell/app/shell_main_delegate.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M athena/main/athena_main.cc View 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
6 years, 5 months ago (2014-07-16 22:22:31 UTC) #1
James Cook
https://codereview.chromium.org/396813003/diff/20001/apps/shell/app/shell_main_delegate.cc File apps/shell/app/shell_main_delegate.cc (right): https://codereview.chromium.org/396813003/diff/20001/apps/shell/app/shell_main_delegate.cc#newcode70 apps/shell/app/shell_main_delegate.cc:70: browser_client_.reset(CreateContentBrowserClient()); Does this call itself? Should this be CreateShellContentBrowserClient()?
6 years, 5 months ago (2014-07-16 22:43:33 UTC) #2
oshima
https://codereview.chromium.org/396813003/diff/20001/apps/shell/app/shell_main_delegate.cc File apps/shell/app/shell_main_delegate.cc (right): https://codereview.chromium.org/396813003/diff/20001/apps/shell/app/shell_main_delegate.cc#newcode70 apps/shell/app/shell_main_delegate.cc:70: browser_client_.reset(CreateContentBrowserClient()); On 2014/07/16 22:43:33, James Cook wrote: > Does ...
6 years, 5 months ago (2014-07-16 22:49:32 UTC) #3
James Cook
LGTM. I wonder if app_shell_browsertests would have caught this issue.
6 years, 5 months ago (2014-07-16 22:54:19 UTC) #4
oshima
On 2014/07/16 22:54:19, James Cook wrote: > LGTM. I wonder if app_shell_browsertests would have caught ...
6 years, 5 months ago (2014-07-16 22:56:29 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-16 22:56:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/396813003/40001
6 years, 5 months ago (2014-07-16 23:00:40 UTC) #7
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-17 17:51:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/396813003/40001
6 years, 5 months ago (2014-07-17 17:54:07 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:27:32 UTC) #10
Message was sent while issue was closed. 
Change committed as 283839

Powered by Google App Engine
This is Rietveld 408576698