dom: Makes ConsoleBase inherit from ScriptWrappable.

dom: Makes ConsoleBase inherit from ScriptWrappable.

Makes ConsoleBase, instead of its subclasses, inherit from ScriptWrappable.

BUG=235436
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178377

[Yuki, 2014-07-17 13:57:50]

Could you review this CL?

[haraken, 2014-07-17 14:29:40]

LGTM

[haraken, 2014-07-17 14:30:30]

BTW, does this cause any issue in your work? This CL is completely fine, and I'm
just curious.

[Yuki, 2014-07-17 14:38:12]

On 2014/07/17 14:30:30, haraken wrote:
> BTW, does this cause any issue in your work? This CL is completely fine, and
I'm
> just curious.

http://crrev.com/398353002 needs this change.  I expect the following class
hierarchy.

    ScriptWrappable <-- ConsoleBase <-- Console / WorkerConsole

With the current code, Console and WorkerConsole inherit from ScriptWrappable,
so we can convert them to ScriptWrappable, but we cannot convert the
ScriptWrappable pointer back to ConsoleBase which is a subclass of Console /
WorkerConsole.  It makes crashes.

[Yuki, 2014-07-17 14:38:20]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2014-07-17 14:38:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yukishiino@chromium.org/396803011/1

[haraken, 2014-07-17 14:41:27]

On 2014/07/17 14:38:12, Yuki wrote:
> On 2014/07/17 14:30:30, haraken wrote:
> > BTW, does this cause any issue in your work? This CL is completely fine, and
> I'm
> > just curious.
> 
> http://crrev.com/398353002 needs this change.  I expect the following class
> hierarchy.
> 
>     ScriptWrappable <-- ConsoleBase <-- Console / WorkerConsole
> 
> With the current code, Console and WorkerConsole inherit from ScriptWrappable,
> so we can convert them to ScriptWrappable, but we cannot convert the
> ScriptWrappable pointer back to ConsoleBase which is a subclass of Console /
> WorkerConsole.  It makes crashes.

Thanks, makes sense. I have some questions but will post them to
http://crrev.com/398353002.

[commit-bot: I haz the power, 2014-07-17 15:43:24]

Change committed as 178377