Tests that the GC doesn't mistake non-pointer constant pool entries as poitners.

Tests that the GC doesn't mistake non-pointer constant pool entries as pointers.

Adds a test for ConstantPoolArray to ensure that the GC
doesn't mistake non-pointer entries as pointers and try
to modify them during scavenge operations.

Also adds asserts to ConstantPoolArray::set(int, *Object) to
ensure we don't add new-space pointers in constant pool
array.

R=hpayer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22608

Committed: https://code.google.com/p/v8/source/detail?r=22634

[rmcilroy, 2014-07-17 12:52:49]

Please take a look, thanks.

[Hannes Payer (out of office), 2014-07-17 15:28:09]

thx! lgtm

[rmcilroy, 2014-07-24 10:17:46]

Fixed test and added asserts to ensure we don't add new space pointers in
constant pool array.

[Hannes Payer (out of office), 2014-07-24 10:37:22]

cool, lgtm

[rmcilroy, 2014-07-24 18:13:28]

Committed patchset #3 manually as r22608 (presubmit successful).

[rmcilroy, 2014-07-25 16:05:19]

On 2014/07/24 18:13:28, rmcilroy wrote:
> Committed patchset #3 manually as r22608 (presubmit successful).

Hannes, I had to revert this because I forgot I was also using new-space
pointers in the other tests.  I've removed this in the new patch set and also
added a test to ensure that compacting is correctly (which was previously being
tested in the original tests using new-space pointers).  If you could have a
quick look at ConstantPoolCompacting to check it makes sense that would be
great.

[Hannes Payer (out of office), 2014-07-28 08:26:07]

LGTM

https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constan...
File test/cctest/test-constantpool.cc (right):

https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constan...
test/cctest/test-constantpool.cc:287: factory->NewFixedDoubleArray(900 * KB /
kDoubleSize, TENURED);
add a check that checks if this fixed double array got allocated in old data
space.

https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constan...
test/cctest/test-constantpool.cc:290:
CHECK(!heap->InNewSpace(heap_ptr->address()));
change this check to CHECK(heap->InOldDataSpace(heap_ptr->address()));

[rmcilroy, 2014-07-28 09:21:05]

Thanks.

https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constan...
File test/cctest/test-constantpool.cc (right):

https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constan...
test/cctest/test-constantpool.cc:287: factory->NewFixedDoubleArray(900 * KB /
kDoubleSize, TENURED);
On 2014/07/28 08:26:07, Hannes Payer wrote:
> add a check that checks if this fixed double array got allocated in old data
> space.

Done.

https://codereview.chromium.org/396803009/diff/60001/test/cctest/test-constan...
test/cctest/test-constantpool.cc:290:
CHECK(!heap->InNewSpace(heap_ptr->address()));
On 2014/07/28 08:26:07, Hannes Payer wrote:
> change this check to CHECK(heap->InOldDataSpace(heap_ptr->address()));

Done.

[rmcilroy, 2014-07-28 10:04:43]

Committed patchset #5 manually as r22634 (presubmit successful).