Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 396803008: Remove some of timeline experiments (Closed)

Created:
6 years, 5 months ago by yurys
Modified:
6 years, 5 months ago
Reviewers:
caseq, alph, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove some of timeline experiments This change removes "Timeline tracing mode" and "Timeline flame chart" experiments. The latter is merged into "Timeline on trace events". BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178376

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased #

Messages

Total messages: 13 (0 generated)
yurys
6 years, 5 months ago (2014-07-17 11:28:05 UTC) #1
caseq
lgtm https://codereview.chromium.org/396803008/diff/1/LayoutTests/inspector/tracing-test.js File LayoutTests/inspector/tracing-test.js (right): https://codereview.chromium.org/396803008/diff/1/LayoutTests/inspector/tracing-test.js#newcode12 LayoutTests/inspector/tracing-test.js:12: InspectorTest.tracingTimelineModel._startRecordingWithCategories("-*,devtools,disabled-by-default-devtools.timeline*"); nit: I think it's about the time ...
6 years, 5 months ago (2014-07-17 11:40:38 UTC) #2
yurys
https://codereview.chromium.org/396803008/diff/1/LayoutTests/inspector/tracing-test.js File LayoutTests/inspector/tracing-test.js (right): https://codereview.chromium.org/396803008/diff/1/LayoutTests/inspector/tracing-test.js#newcode12 LayoutTests/inspector/tracing-test.js:12: InspectorTest.tracingTimelineModel._startRecordingWithCategories("-*,devtools,disabled-by-default-devtools.timeline*"); On 2014/07/17 11:40:38, caseq wrote: > nit: I ...
6 years, 5 months ago (2014-07-17 11:45:19 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-07-17 11:45:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/396803008/20001
6 years, 5 months ago (2014-07-17 11:46:23 UTC) #5
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-07-17 12:37:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/396803008/40001
6 years, 5 months ago (2014-07-17 12:37:48 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-17 13:40:49 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 13:42:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/12836)
6 years, 5 months ago (2014-07-17 13:42:06 UTC) #10
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-07-17 14:07:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/396803008/60001
6 years, 5 months ago (2014-07-17 14:07:50 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 15:18:43 UTC) #13
Message was sent while issue was closed.
Change committed as 178376

Powered by Google App Engine
This is Rietveld 408576698