Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 396793003: Factorize media/audio into new GN. (Closed)

Created:
6 years, 5 months ago by DaleCurtis
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Factorize media/audio into new GN. Breaks out one of the most complex media/ targets into its own BUILD.gn file for improved readibility and targetting. BUG=none TEST=media_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284314

Patch Set 1 : Rebase. #

Patch Set 2 : Update DEPS. #

Patch Set 3 : Add missing audio deps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+402 lines, -284 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 18 chunks +15 lines, -281 lines 0 comments Download
A media/audio/BUILD.gn View 1 chunk +331 lines, -0 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 2 chunks +10 lines, -2 lines 0 comments Download
A media/media_options.gni View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
DaleCurtis
6 years, 5 months ago (2014-07-16 20:24:17 UTC) #1
DaleCurtis
Rebased. PTAL.
6 years, 5 months ago (2014-07-18 19:34:04 UTC) #2
brettw
lgtm
6 years, 5 months ago (2014-07-18 19:42:33 UTC) #3
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-18 20:49:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/396793003/60001
6 years, 5 months ago (2014-07-18 20:51:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 00:33:33 UTC) #6
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-19 01:20:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/396793003/80001
6 years, 5 months ago (2014-07-19 01:21:22 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 04:59:57 UTC) #9
Message was sent while issue was closed. 
Change committed as 284314

Powered by Google App Engine
This is Rietveld 408576698