Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: tools/perf/benchmarks/smoothness.py

Issue 396783008: Re-enable Polymer benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/smoothness.py
diff --git a/tools/perf/benchmarks/smoothness.py b/tools/perf/benchmarks/smoothness.py
index d54c4ec2d4dfcc2c88947ff0cdbd36104942c004..1c5f4991cefd9b383b0fa32abda6520e4ed8fa2c 100644
--- a/tools/perf/benchmarks/smoothness.py
+++ b/tools/perf/benchmarks/smoothness.py
@@ -66,7 +66,8 @@ class SmoothnessFastPathKeySilkCases(benchmark.Benchmark):
silk_flags.CustomizeBrowserOptionsForFastPath(options)
-@benchmark.Disabled('j') # crbug.com/363783
+# GPU rasterization does not work on J devices
+@benchmark.Disabled('j')
class SmoothnessGpuRasterizationTop25(benchmark.Benchmark):
"""Measures rendering statistics for the top 25 with GPU rasterization
"""
@@ -77,7 +78,8 @@ class SmoothnessGpuRasterizationTop25(benchmark.Benchmark):
silk_flags.CustomizeBrowserOptionsForGpuRasterization(options)
-@benchmark.Disabled('j') # crbug.com/363783
+# GPU rasterization does not work on J devices
+@benchmark.Disabled('j')
class SmoothnessGpuRasterizationKeyMobileSites(benchmark.Benchmark):
"""Measures rendering statistics for the key mobile sites with GPU
rasterization
@@ -122,7 +124,6 @@ class SmoothnessToughPinchZoomCases(benchmark.Benchmark):
page_set = page_sets.ToughPinchZoomCasesPageSet
-@benchmark.Disabled # crbug.com/370725
class SmoothnessPolymer(benchmark.Benchmark):
"""Measures rendering statistics for Polymer cases.
"""
@@ -130,7 +131,6 @@ class SmoothnessPolymer(benchmark.Benchmark):
page_set = page_sets.PolymerPageSet
-@benchmark.Disabled # crbug.com/370725
class SmoothnessFastPathPolymer(benchmark.Benchmark):
"""Measures rendering statistics for the Polymer cases without GPU
rasterization using bleeding edge rendering fast paths.
@@ -141,8 +141,8 @@ class SmoothnessFastPathPolymer(benchmark.Benchmark):
def CustomizeBrowserOptions(self, options):
silk_flags.CustomizeBrowserOptionsForFastPath(options)
-
-@benchmark.Disabled # crbug.com/370725
+# GPU rasterization does not work on J devices
+@benchmark.Disabled('j')
class SmoothnessGpuRasterizationPolymer(benchmark.Benchmark):
"""Measures rendering statistics for the Polymer cases with GPU rasterization
"""
@@ -153,7 +153,6 @@ class SmoothnessGpuRasterizationPolymer(benchmark.Benchmark):
silk_flags.CustomizeBrowserOptionsForGpuRasterization(options)
-@benchmark.Disabled # crbug.com/370725
class SmoothnessFastPathGpuRasterizationPolymer(
SmoothnessGpuRasterizationPolymer):
"""Measures rendering statistics for the Polymer cases with GPU rasterization
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698