Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 396773002: [Profiles] Create a profile moar better after deleting the only existing profile. (Closed)

Created:
6 years, 5 months ago by noms (inactive)
Modified:
6 years, 5 months ago
Reviewers:
Elliot Glaysher, sky, erg
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Profiles] Create a profile moar better after deleting the only existing profile. The problem was that we only created the new profile if we deleted the active profile, and it was the only existing profile. Since guest mode came along, we could also delete the only profile when the active profile was the guest one (which doesn't really count as a profile), so you'd be left in this borked state of "no profiles in Chrome, oops". For brownie points, I also added tests for both of these "only existing profile deleted" scenarios. :) BUG=393901 TEST=See bug description. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284096

Patch Set 1 #

Patch Set 2 : undo changes to TestingProfile because they broke everything #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -2 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
noms (inactive)
Hiya Elliot, Rachel is on vacation, so you're my de-facto Profiles owner of choice :) ...
6 years, 5 months ago (2014-07-15 21:17:15 UTC) #1
erg
lgtm
6 years, 5 months ago (2014-07-15 21:39:12 UTC) #2
noms (inactive)
+ sky for chrome/test/base stamp
6 years, 5 months ago (2014-07-15 23:42:12 UTC) #3
sky
LGTM
6 years, 5 months ago (2014-07-16 14:38:24 UTC) #4
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 5 months ago (2014-07-16 14:50:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/396773002/1
6 years, 5 months ago (2014-07-16 14:53:58 UTC) #6
noms (inactive)
The CQ bit was unchecked by noms@chromium.org
6 years, 5 months ago (2014-07-16 19:23:16 UTC) #7
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 5 months ago (2014-07-17 17:17:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/396773002/100001
6 years, 5 months ago (2014-07-17 17:18:31 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 19:51:17 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 20:15:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172089)
6 years, 5 months ago (2014-07-17 20:15:03 UTC) #12
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 5 months ago (2014-07-18 14:15:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/396773002/100001
6 years, 5 months ago (2014-07-18 14:15:53 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 14:39:01 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 15:39:38 UTC) #16
Message was sent while issue was closed.
Change committed as 284096

Powered by Google App Engine
This is Rietveld 408576698