Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 396743002: Remove redundant WebContents field in WebContentsObserver implementation (Closed)

Created:
6 years, 5 months ago by dcheng
Modified:
6 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove redundant WebContents field in WebContentsObserver implementation BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/dom_distiller/tab_utils.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dcheng
Just some simple cleanup you pointed out in one of my earlier patches.
6 years, 5 months ago (2014-07-15 19:30:47 UTC) #1
nyquist
lgtm! thanks!
6 years, 5 months ago (2014-07-15 20:20:31 UTC) #2
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-15 20:35:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/396743002/1
6 years, 5 months ago (2014-07-15 20:39:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 05:09:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 05:32:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171070)
6 years, 5 months ago (2014-07-16 05:32:57 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 5 months ago (2014-07-16 17:16:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/396743002/1
6 years, 5 months ago (2014-07-16 17:19:29 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:40:02 UTC) #10
Message was sent while issue was closed. 
Change committed as 283453

Powered by Google App Engine
This is Rietveld 408576698