Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 396733009: move compile guard into chrome (Closed)

Created:
6 years, 5 months ago by reed1
Modified:
6 years, 5 months ago
Reviewers:
f(malita), reed2
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

move compile guard into chrome will remove the flag from the skia side after this lands BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
6 years, 5 months ago (2014-07-16 14:47:39 UTC) #1
f(malita)
lgtm
6 years, 5 months ago (2014-07-16 14:49:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/396733009/1
6 years, 5 months ago (2014-07-16 14:50:55 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 20:22:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 00:34:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/39625)
6 years, 5 months ago (2014-07-17 00:34:34 UTC) #6
reed2
The CQ bit was checked by reed@chromium.org
6 years, 5 months ago (2014-07-17 03:03:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/396733009/1
6 years, 5 months ago (2014-07-17 03:06:44 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 05:09:08 UTC) #9
Message was sent while issue was closed. 
Change committed as 283649

Powered by Google App Engine
This is Rietveld 408576698