runtime/vm/intermediate_language.h - Issue 396733006: Optimize the multiplication of two 32-bit unsigned integers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.h

Issue 396733006: Optimize the multiplication of two 32-bit unsigned integers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.h

===================================================================

--- runtime/vm/intermediate_language.h (revision 38266)

+++ runtime/vm/intermediate_language.h (working copy)

@@ -7086,7 +7086,8 @@

virtual bool CanDeoptimize() const {

return FLAG_throw_on_javascript_int_overflow

|| (can_overflow() && ((op_kind() == Token::kADD) ||

- (op_kind() == Token::kSUB)));

+ (op_kind() == Token::kSUB)))

+ || (op_kind() == Token::kMUL);

}

virtual Representation representation() const {

@@ -8073,7 +8074,7 @@

virtual void PrintOperandsTo(BufferFormatter* f) const;

virtual bool CanDeoptimize() const {

- return false;

+ return op_kind_ == Token::kMUL;

}

virtual Representation representation() const {

« runtime/vm/flow_graph_optimizer.cc ('K') | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_arm.cc » ('j') | runtime/vm/intermediate_language_arm.cc » ('J')