Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 396653003: Changing the string for input permission warning to include "change". (Closed)

Created:
6 years, 5 months ago by mhm
Modified:
6 years, 5 months ago
Reviewers:
jww
CC:
chromium-reviews, meacer, kevers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changing the string for input permission warning to include "change". chrome.input API allows modifying text as an IME, but the warning only says "Read anything you type". It should say "Read and change anything you type". BUG=388535 R=jww Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mhm
jww@ can you please have a look at this for me.
6 years, 5 months ago (2014-07-15 22:46:29 UTC) #1
jww
lgtm
6 years, 5 months ago (2014-07-15 23:02:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/396653003/1
6 years, 5 months ago (2014-07-15 23:04:18 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 07:36:59 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 18:56:18 UTC) #5
Message was sent while issue was closed.
Change committed as 283460

Powered by Google App Engine
This is Rietveld 408576698