pkg/source_span/lib/src/span_exception.dart - Issue 396603003: Change "FormatException.position" to be named "offset".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/source_span/lib/src/span_exception.dart

Issue 396603003: Change "FormatException.position" to be named "offset". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Reapply change, with necessary fixes in span_execption.dart Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/source_span/lib/src/span_exception.dart

diff --git a/pkg/source_span/lib/src/span_exception.dart b/pkg/source_span/lib/src/span_exception.dart

index af642413bdda0c2a1a6c20c459b40bd4e4334a5f..36f2488329d1331589ab9dc3f1635e7ba81a7cd4 100644

--- a/pkg/source_span/lib/src/span_exception.dart

+++ b/pkg/source_span/lib/src/span_exception.dart

@@ -36,7 +36,7 @@ class SourceSpanFormatException extends SourceSpanException

implements FormatException {

final source;

- int get position => span == null ? null : span.start.offset;

+ int get offset => span == null ? null : span.start.offset;

SourceSpanFormatException(String message, SourceSpan span, [this.source])

: super(message, span);

« no previous file with comments | « pkg/source_maps/pubspec.yaml ('k') | sdk/lib/core/exceptions.dart » ('j') | no next file with comments »