Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 396563002: Window Manager service.. (Closed)

Created:
6 years, 5 months ago by Ben Goodger (Google)
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add the skeleton of a window manager service and a CreateWindow method. R=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283786

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : , #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 1

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -0 lines) Patch
M mojo/mojo.gyp View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 4 5 6 7 8 9 10 2 chunks +71 lines, -0 lines 0 comments Download
A mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 2 3 4 1 chunk +24 lines, -0 lines 0 comments Download
A mojo/services/window_manager/DEPS View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
A mojo/services/window_manager/window_manager_api_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +116 lines, -0 lines 0 comments Download
A mojo/services/window_manager/window_manager_app.h View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
A mojo/services/window_manager/window_manager_app.cc View 1 2 3 4 1 chunk +118 lines, -0 lines 0 comments Download
A mojo/services/window_manager/window_manager_service_impl.h View 1 2 3 4 1 chunk +42 lines, -0 lines 0 comments Download
A mojo/services/window_manager/window_manager_service_impl.cc View 1 2 3 4 1 chunk +56 lines, -0 lines 0 comments Download
A mojo/services/window_manager/window_manager_unittests.cc View 1 2 3 4 5 6 1 chunk +43 lines, -0 lines 0 comments Download
M mojo/shell/shell_test_helper.cc View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
https://codereview.chromium.org/396563002/diff/120001/mojo/services/public/interfaces/window_manager/window_manager.mojom File mojo/services/public/interfaces/window_manager/window_manager.mojom (right): https://codereview.chromium.org/396563002/diff/120001/mojo/services/public/interfaces/window_manager/window_manager.mojom#newcode9 mojo/services/public/interfaces/window_manager/window_manager.mojom:9: OpenWindow() => (uint32 node_id); I suspect I may not ...
6 years, 5 months ago (2014-07-16 20:52:35 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-16 21:06:48 UTC) #2
Ben Goodger (Google)
6 years, 5 months ago (2014-07-17 15:39:08 UTC) #3
Message was sent while issue was closed. 
Committed patchset #11 manually as r283786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698