Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: components/dom_distiller/content/distiller_page_web_contents_browsertest.cc

Issue 396503003: DomDistiller: fix 0 document width (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: resolve patch conflicts Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
diff --git a/components/dom_distiller/content/distiller_page_web_contents_browsertest.cc b/components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
index 7e7aa0210f7e291548abe2866eb71d8c4c3aaefc..74159eb677cfa356d74cf6b0c0d394d73c687361 100644
--- a/components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
+++ b/components/dom_distiller/content/distiller_page_web_contents_browsertest.cc
@@ -89,9 +89,10 @@ class TestDistillerPageWebContents : public DistillerPageWebContents {
public:
TestDistillerPageWebContents(
content::BrowserContext* browser_context,
+ const gfx::Size& render_view_size,
scoped_ptr<SourcePageHandleWebContents> optional_web_contents_handle,
bool expect_new_web_contents)
- : DistillerPageWebContents(browser_context,
+ : DistillerPageWebContents(browser_context, render_view_size,
optional_web_contents_handle.Pass()),
expect_new_web_contents_(expect_new_web_contents),
new_web_contents_created_(false) {}
@@ -161,6 +162,7 @@ class WebContentsMainFrameHelper : public content::WebContentsObserver {
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, BasicDistillationWorks) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
+ shell()->web_contents()->GetContainerBounds().size(),
scoped_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
@@ -178,6 +180,7 @@ IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, BasicDistillationWorks) {
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeLinks) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
+ shell()->web_contents()->GetContainerBounds().size(),
scoped_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
@@ -195,6 +198,7 @@ IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeLinks) {
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeImages) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
+ shell()->web_contents()->GetContainerBounds().size(),
scoped_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
@@ -213,6 +217,7 @@ IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeImages) {
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeVideos) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
+ shell()->web_contents()->GetContainerBounds().size(),
scoped_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
@@ -238,6 +243,7 @@ IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, HandlesRelativeVideos) {
IN_PROC_BROWSER_TEST_F(DistillerPageWebContentsTest, VisibilityDetection) {
DistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
+ shell()->web_contents()->GetContainerBounds().size(),
scoped_ptr<SourcePageHandleWebContents>());
distiller_page_ = &distiller_page;
@@ -334,6 +340,7 @@ void DistillerPageWebContentsTest::RunUseCurrentWebContentsTest(
TestDistillerPageWebContents distiller_page(
shell()->web_contents()->GetBrowserContext(),
+ shell()->web_contents()->GetContainerBounds().size(),
source_page_handle.Pass(),
expect_new_web_contents);
distiller_page_ = &distiller_page;

Powered by Google App Engine
This is Rietveld 408576698