chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc - Issue 396493004: Get rid of some uses of CreateDoubleValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

Issue 396493004: Get rid of some uses of CreateDoubleValue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_impl.cc ('K') | « chrome/browser/profiles/profile_impl.cc ('k') | chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

diff --git a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

index 59eae7d2d79241f01bb910c8fe874eade7beff4d..ff620ec5875d5a54ba3f60619ae40595de123a3b 100644

--- a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

+++ b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

@@ -285,9 +285,9 @@ void DoGetEvents(base::ListValue* results,

LOG(ERROR) << "Failed to get 'time' field from event.";

continue;

}

- value = base::Value::CreateDoubleValue(

- base::Time::FromInternalValue(

- static_cast<int64>(time)).ToJsTime());

+ value = new base::FundamentalValue(

+ base::Time::FromInternalValue(static_cast<int64>(time))

+ .ToJsTime());

} else {

// All other values are user-facing, so we create a new value for

// localized display.