Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 396493004: Get rid of some uses of CreateDoubleValue (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Get rid of some uses of CreateDoubleValue BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283348

Patch Set 1 #

Total comments: 2

Patch Set 2 : right number of args + fix lint error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M chrome/browser/extensions/api/web_view/web_view_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_hash_calculator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
6 years, 5 months ago (2014-07-15 00:06:36 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/396493004/diff/1/chrome/browser/profiles/profile_impl.cc File chrome/browser/profiles/profile_impl.cc (right): https://codereview.chromium.org/396493004/diff/1/chrome/browser/profiles/profile_impl.cc#newcode1080 chrome/browser/profiles/profile_impl.cc:1080: host_zoom_dictionary->SetDoubleWithoutPathExpansion(level); s/level/change.host, level/ ?
6 years, 5 months ago (2014-07-15 00:18:01 UTC) #2
Evan Stade
https://codereview.chromium.org/396493004/diff/1/chrome/browser/profiles/profile_impl.cc File chrome/browser/profiles/profile_impl.cc (right): https://codereview.chromium.org/396493004/diff/1/chrome/browser/profiles/profile_impl.cc#newcode1080 chrome/browser/profiles/profile_impl.cc:1080: host_zoom_dictionary->SetDoubleWithoutPathExpansion(level); On 2014/07/15 00:18:01, Lei Zhang wrote: > s/level/change.host, ...
6 years, 5 months ago (2014-07-15 19:23:32 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-15 19:25:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/396493004/20001
6 years, 5 months ago (2014-07-15 19:30:32 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 05:04:05 UTC) #6
Message was sent while issue was closed.
Change committed as 283348

Powered by Google App Engine
This is Rietveld 408576698