Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 396483003: Separate ResizeHelper from RenderWidgetHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make dtor order more robust Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index c629485f9059f0cd40fdcc431afc5543dfdf0eae..51e1a6884ddab1a50dd07ab80975bb7bcd84da7b 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -950,19 +950,6 @@ void RenderProcessHostImpl::RemoveObserver(
observers_.RemoveObserver(observer);
}
-bool RenderProcessHostImpl::WaitForBackingStoreMsg(
- int render_widget_id,
- const base::TimeDelta& max_delay,
- IPC::Message* msg) {
- // The post task to this thread with the process id could be in queue, and we
- // don't want to dispatch a message before then since it will need the handle.
- if (child_process_launcher_.get() && child_process_launcher_->IsStarting())
- return false;
-
- return widget_helper_->WaitForBackingStoreMsg(render_widget_id,
- max_delay, msg);
-}
-
void RenderProcessHostImpl::ReceivedBadMessage() {
CommandLine* command_line = CommandLine::ForCurrentProcess();
if (command_line->HasSwitch(switches::kDisableKillAfterBadIPC))
@@ -1405,13 +1392,6 @@ bool RenderProcessHostImpl::OnMessageReceived(const IPC::Message& msg) {
reply->set_reply_error();
Send(reply);
}
-
- // If this is a SwapBuffers, we need to ack it if we're not going to handle
- // it so that the GPU process doesn't get stuck in unscheduled state.
- IPC_BEGIN_MESSAGE_MAP(RenderProcessHostImpl, msg)
- IPC_MESSAGE_HANDLER(ViewHostMsg_CompositorSurfaceBuffersSwapped,
- OnCompositorSurfaceBuffersSwappedNoHost)
- IPC_END_MESSAGE_MAP()
return true;
}
return listener->OnMessageReceived(msg);
@@ -2142,20 +2122,6 @@ void RenderProcessHostImpl::OnSavedPageAsMHTML(int job_id, int64 data_size) {
MHTMLGenerationManager::GetInstance()->MHTMLGenerated(job_id, data_size);
}
-void RenderProcessHostImpl::OnCompositorSurfaceBuffersSwappedNoHost(
- const ViewHostMsg_CompositorSurfaceBuffersSwapped_Params& params) {
- TRACE_EVENT0("renderer_host",
- "RenderWidgetHostImpl::OnCompositorSurfaceBuffersSwappedNoHost");
- if (!ui::LatencyInfo::Verify(params.latency_info,
- "ViewHostMsg_CompositorSurfaceBuffersSwapped"))
- return;
- AcceleratedSurfaceMsg_BufferPresented_Params ack_params;
- ack_params.sync_point = 0;
- RenderWidgetHostImpl::AcknowledgeBufferPresent(params.route_id,
- params.gpu_process_host_id,
- ack_params);
-}
-
void RenderProcessHostImpl::OnGpuSwitching() {
// We are updating all widgets including swapped out ones.
scoped_ptr<RenderWidgetHostIterator> widgets(
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | content/browser/renderer_host/render_widget_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698