Make ObserverList non-inline to save save 90 KB with gcc

Make ObserverList non-inline to save 90KB with gcc

With gcc, ObserverList expands to 6-700 bytes every time it is 
iterated. By not trying to force OberservListBase to be inline
that shrinks some. clang already ignores the hints to inline 
the code and actually doesn't change a single bit in the generated
program with this change.

raw data:
Total change: -90875 bytes
==========================
  262 added, totalling +39188 bytes across 2 sources
  49 removed, totalling -27573 bytes across 16 sources
  23 grown, for a net change of +3600 bytes (34968 bytes before, 38568 bytes after) across 8 sources
  228 shrunk, for a net change of -106090 bytes (239819 bytes before, 133729 bytes after) across 53 sources

The additions is about 2-300 different flavours of ObserverListBase, 100-300 bytes each.

The savings are 200-600 bytes each every time an observer list is used. For example:

-870: content::RenderFrameImpl::didFailLoad(blink::WebLocalFrame*, blink::WebURLError const&) type=t, (was 1635 bytes, 
now 765 bytes)
-895: content::RenderFrameImpl::didFinishLoad(blink::WebLocalFrame*) type=t, (was 1646 bytes, now 751 bytes)
-583: content::WebContentsImpl::DidFailProvisionalLoadWithError(content::RenderFrameHostImpl*, FrameHostMsg_DidFailProvisionalLoadWithError_Params const&) type=t, (was 768 bytes, now 185 bytes)
-611: content::WebContentsImpl::DidStartProvisionalLoad(content::RenderFrameHostImpl*, GURL const&, bool, bool) type=t, (was 895 bytes, now 284 bytes)

BUG=394311
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283762

[Daniel Bratell, 2014-07-16 12:41:34]

jar, can you please take a look at this patch? I've not changed any code, just
moved it around a little.

[jar (doing other things), 2014-07-16 23:00:46]

I'm not currently a base reviewer... to passing along to Brett, or Will (who
might like playing with and commenting on templates even more than Brett).

[willchan no longer on Chromium, 2014-07-16 23:19:18]

LGTM, although I caught some indentation issues when you moved the code.

Thanks so much for working on these code size issues. I very much appreciate
this work.

https://codereview.chromium.org/396473004/diff/1/base/observer_list.h
File base/observer_list.h (right):

https://codereview.chromium.org/396473004/diff/1/base/observer_list.h#newcode132
base/observer_list.h:132: std::numeric_limits<size_t>::max() :
indentation is off here

https://codereview.chromium.org/396473004/diff/1/base/observer_list.h#newcode191
base/observer_list.h:191: it != observers_.end(); ++it) {
indentation is off here

[Daniel Bratell, 2014-07-17 09:40:24]

https://codereview.chromium.org/396473004/diff/1/base/observer_list.h
File base/observer_list.h (right):

https://codereview.chromium.org/396473004/diff/1/base/observer_list.h#newcode132
base/observer_list.h:132: std::numeric_limits<size_t>::max() :
On 2014/07/16 23:19:18, willchan wrote:
> indentation is off here

Acknowledged.

https://codereview.chromium.org/396473004/diff/1/base/observer_list.h#newcode191
base/observer_list.h:191: it != observers_.end(); ++it) {
On 2014/07/16 23:19:18, willchan wrote:
> indentation is off here

Acknowledged.

[Daniel Bratell, 2014-07-17 09:40:29]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-17 09:42:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/396473004/20001

[commit-bot: I haz the power, 2014-07-17 12:39:39]

Change committed as 283762