Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 396413002: [MemSheriff] WebCore is now blink (Closed)

Created:
6 years, 5 months ago by groby-ooo-7-16
Modified:
6 years, 5 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mem-394558
Project:
chromium
Visibility:
Public.

Description

[MemSheriff] WebCore is now blink namespace WebCore became namespace blink in blink's r178289 (http://src.chromium.org/viewvc/blink?view=revision&revision=178289) WebKit DEPS have now rolled, this updates the suppressions to catch up. All replacements done via a single command: grep -rl 'fun:_ZN7WebCore' tools/valgrind/memcheck |\ xargs sed -i 's/fun:_ZN7WebCore/fun:_ZN5blink/' BUG=none TBR=thestig@chromium.org, abarth@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -697 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 119 chunks +595 lines, -595 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 9 chunks +102 lines, -102 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
groby-ooo-7-16
6 years, 5 months ago (2014-07-16 22:59:29 UTC) #1
Lei Zhang
lgtm
6 years, 5 months ago (2014-07-16 23:02:13 UTC) #2
groby-ooo-7-16
The CQ bit was checked by groby@chromium.org
6 years, 5 months ago (2014-07-16 23:17:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/396413002/1
6 years, 5 months ago (2014-07-16 23:19:50 UTC) #4
commit-bot: I haz the power
Change committed as 283587
6 years, 5 months ago (2014-07-16 23:49:01 UTC) #5
abarth-chromium
The change hasn't quite rolled in. I rolled to the rev right before. It should ...
6 years, 5 months ago (2014-07-17 00:06:24 UTC) #6
groby-ooo-7-16
That is odd, because the memory bots saw a _ton_ of leaks with blink namespace ...
6 years, 5 months ago (2014-07-17 00:08:58 UTC) #7
abarth-chromium
6 years, 5 months ago (2014-07-17 00:23:25 UTC) #8
Message was sent while issue was closed.
On 2014/07/17 at 00:08:58, groby wrote:
> That is odd, because the memory bots saw a _ton_ of leaks with blink namespace
suddenly..

Oh, maybe I got the rev numbers wrong.

Powered by Google App Engine
This is Rietveld 408576698