third_party/harfbuzz-ng/src/hb-unicode.cc - Issue 396393005: Roll HarfBuzz to 0.9.32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/src/hb-unicode.cc

Issue 396393005: Roll HarfBuzz to 0.9.32 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for include order presubmit issue Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/src/hb-unicode.cc

diff --git a/third_party/harfbuzz-ng/src/hb-unicode.cc b/third_party/harfbuzz-ng/src/hb-unicode.cc

index ed99ca211dd04f567ee8f7cb56f42b33af7acd2a..84e5c06fd35206ae53cb2dbce64c4bd25d318136 100644

--- a/third_party/harfbuzz-ng/src/hb-unicode.cc

+++ b/third_party/harfbuzz-ng/src/hb-unicode.cc

@@ -146,8 +146,13 @@ hb_unicode_funcs_get_default (void)

}

#if !defined(HB_NO_UNICODE_FUNCS) && defined(HB_UNICODE_FUNCS_NIL)

-#pragma message("Could not find any Unicode functions implementation, you have to provide your own.")

-#pragma message("To suppress this warnings, define HB_NO_UNICODE_FUNCS.")

+#ifdef _MSC_VER

+#pragma message("Could not find any Unicode functions implementation, you have to provide your own")

+#pragma message("To suppress this warnings, define HB_NO_UNICODE_FUNCS")

+#else

+#warning "Could not find any Unicode functions implementation, you have to provide your own"

+#warning "To suppress this warning, define HB_NO_UNICODE_FUNCS"

+#endif

#endif

/**