Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 396343002: Remove unneeded ASSERT in StyleResolver::styleSharingList (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unneeded ASSERT in StyleResolver::styleSharingList Remove unneeded ASSERT in StyleResolver::styleSharingList, the unsigned can't be negative so don't check for it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-16 19:45:01 UTC) #1
esprehn
lgtm
6 years, 5 months ago (2014-07-16 19:46:30 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-16 19:48:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/396343002/1
6 years, 5 months ago (2014-07-16 19:50:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-16 20:51:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 22:05:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17346)
6 years, 5 months ago (2014-07-16 22:05:13 UTC) #7
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 5 months ago (2014-07-16 22:53:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/396343002/1
6 years, 5 months ago (2014-07-16 22:54:41 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:59:48 UTC) #10
Message was sent while issue was closed.
Change committed as 178333

Powered by Google App Engine
This is Rietveld 408576698