Issue 396313002: Fix header inclusion of chrome_template_url_service_client.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396313002: Fix header inclusion of chrome_template_url_service_client.cc (Closed)

Created:
6 years, 5 months ago by Jiang Jiang

Modified:
6 years, 5 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix header inclusion of chrome_template_url_service_client.cc chrome_template_url_service_client.cc should include chrome/browser/history/history_notifications.h as it's using history::URLVisitedDetails declared there. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283747

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/search_engines/chrome_template_url_service_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/396313002/1

6 years, 5 months ago (2014-07-17 07:26:59 UTC) #4

Message was sent while issue was closed.

Change committed as 283747

Expand Messages | Collapse Messages