Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 396303002: Allow building search_engines component with configuration_policy==0 (Closed)

Created:
6 years, 5 months ago by Jiang Jiang
Modified:
6 years, 5 months ago
Reviewers:
Peter Kasting, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow building search_engines component with configuration_policy==0 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284009

Patch Set 1 #

Patch Set 2 : Rebase and fix GN build #

Patch Set 3 : Correct GN syntax #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M components/search_engines.gypi View 1 1 chunk +11 lines, -0 lines 0 comments Download
M components/search_engines/BUILD.gn View 1 2 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jiang Jiang
6 years, 5 months ago (2014-07-16 17:09:59 UTC) #1
Jiang Jiang
Peter, can you please review this one as well?
6 years, 5 months ago (2014-07-17 12:24:35 UTC) #2
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-17 17:57:10 UTC) #3
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 5 months ago (2014-07-17 18:53:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/396303002/1
6 years, 5 months ago (2014-07-17 18:57:02 UTC) #5
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 5 months ago (2014-07-17 22:15:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/396303002/60001
6 years, 5 months ago (2014-07-17 22:16:37 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 05:33:54 UTC) #8
Message was sent while issue was closed.
Change committed as 284009

Powered by Google App Engine
This is Rietveld 408576698