Enable Android lint by default

Enable Android lint by default

BUG=393235
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287676

[cjhopman, 2014-07-30 17:37:01]

yfriedman: *

[Yaron, 2014-07-30 17:39:44]

On 2014/07/30 17:37:01, cjhopman wrote:
> yfriedman: *

How much time does this add to an incremental build?

[cjhopman, 2014-07-30 17:40:35]

On 2014/07/30 17:39:44, Yaron wrote:
> On 2014/07/30 17:37:01, cjhopman wrote:
> > yfriedman: *
> 
> How much time does this add to an incremental build?

None, usually. Typically, running lint on a library is faster than dexing it.

[Yaron, 2014-07-30 17:44:48]

On 2014/07/30 17:40:35, cjhopman wrote:
> On 2014/07/30 17:39:44, Yaron wrote:
> > On 2014/07/30 17:37:01, cjhopman wrote:
> > > yfriedman: *
> > 
> > How much time does this add to an incremental build?
> 
> None, usually. Typically, running lint on a library is faster than dexing it.

lgtm

[cjhopman, 2014-07-30 17:55:20]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-07-30 17:57:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cjhopman@chromium.org/396293002/1

[commit-bot: I haz the power, 2014-07-30 19:39:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-30 20:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-30 20:04:57]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[cjhopman, 2014-08-05 23:09:47]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-08-05 23:12:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cjhopman@chromium.org/396293002/20001

[commit-bot: I haz the power, 2014-08-06 04:37:08]

Change committed as 287676

[aberent, 2014-08-06 10:20:03]

A revert of this CL has been created in
https://codereview.chromium.org/446833002/ by aberent@chromium.org.

The reason for reverting is: Two Android build bots (downstream) are failing as
a result of this CL.

Reverting as Android Build Sheriff.

BUG=401020
TBR=cjhopman
NO_TRY=true
.

[Yaron, 2014-08-06 16:10:45]

On 2014/08/06 10:20:03, aberent wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/446833002/ by mailto:aberent@chromium.org.
> 
> The reason for reverting is: Two Android build bots (downstream) are failing
as
> a result of this CL.
> 
> Reverting as Android Build Sheriff.
> 
> BUG=401020
> TBR=cjhopman
> NO_TRY=true
> .

Could you not fix or just temporarily whitelist the issues downstream? We should
not revert chromium changes for breakages downstream

[cjhopman, 2014-08-06 16:16:52]

Lint failures shouldn't actually break the build. Or rather, when lint runs
correctly but finds problems, it should print them but not fail the build.
Currently, if lint fails, then it fails the build. I think I'll just make
it print whatever error it has and succeed.

Is the arm64 builder an L builder? This could just be a problem with lint
w/ L.


On Wed, Aug 6, 2014 at 9:10 AM, <yfriedman@chromium.org> wrote:

> On 2014/08/06 10:20:03, aberent wrote:
>
>> A revert of this CL has been created in
>> https://codereview.chromium.org/446833002/ by mailto:aberent@chromium.org
>> .
>>
>
>  The reason for reverting is: Two Android build bots (downstream) are
>> failing
>>
> as
>
>> a result of this CL.
>>
>
>  Reverting as Android Build Sheriff.
>>
>
>  BUG=401020
>> TBR=cjhopman
>> NO_TRY=true
>> .
>>
>
> Could you not fix or just temporarily whitelist the issues downstream? We
> should
> not revert chromium changes for breakages downstream
>
> https://codereview.chromium.org/396293002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cjhopman, 2014-08-06 16:22:07]

yfriedman: ptal again

[cjhopman, 2014-08-06 16:22:59]

On 2014/08/06 16:22:07, cjhopman wrote:
> yfriedman: ptal again

just kidding, not this one