Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: Source/core/css/MediaQueryListTest.cpp

Issue 396283004: Make the MediaQueryList listener an EventListener (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/MediaQueryListListener.cpp ('k') | Source/core/css/MediaQueryMatcher.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/css/MediaQueryList.h" 6 #include "core/css/MediaQueryList.h"
7 7
8 #include "bindings/core/v8/V8Binding.h"
9 #include "core/css/MediaList.h" 8 #include "core/css/MediaList.h"
10 #include "core/css/MediaQueryListListener.h" 9 #include "core/css/MediaQueryListListener.h"
11 #include "core/css/MediaQueryMatcher.h" 10 #include "core/css/MediaQueryMatcher.h"
12 #include "core/dom/Document.h" 11 #include "core/dom/Document.h"
13 #include <gtest/gtest.h> 12 #include <gtest/gtest.h>
14 13
14 namespace {
15
16 class TestListener : public blink::MediaQueryListListener {
17 public:
18 virtual void call() OVERRIDE { }
19 };
20
21 }
22
15 namespace blink { 23 namespace blink {
16 24
17 TEST(MediaQueryListTest, CrashInStop) 25 TEST(MediaQueryListTest, CrashInStop)
18 { 26 {
19 V8TestingScope scope(v8::Isolate::GetCurrent());
20 RefPtrWillBeRawPtr<Document> document = Document::create(); 27 RefPtrWillBeRawPtr<Document> document = Document::create();
21 RefPtrWillBeRawPtr<MediaQueryList> list = MediaQueryList::create(document.ge t(), MediaQueryMatcher::create(*document), MediaQuerySet::create()); 28 RefPtrWillBeRawPtr<MediaQueryList> list = MediaQueryList::create(document.ge t(), MediaQueryMatcher::create(*document), MediaQuerySet::create());
22 v8::Local<v8::FunctionTemplate> templ = v8::FunctionTemplate::New(scope.isol ate()); 29 list->addListener(adoptRefWillBeNoop(new TestListener()));
23 list->addListener(MediaQueryListListener::create(scope.scriptState(), Script Value(scope.scriptState(), templ->GetFunction())));
24 // Now, MediaQueryList and MediaQueryListListener have reference cycle. We 30 // Now, MediaQueryList and MediaQueryListListener have reference cycle. We
25 // can clear |list|. 31 // can clear |list|.
26 MediaQueryList* rawList = list.release().get(); 32 MediaQueryList* rawList = list.release().get();
27 rawList->stop(); 33 rawList->stop();
28 // This test passes if it's not crashed. 34 // This test passes if it's not crashed.
29 } 35 }
30 36
31 } 37 }
OLDNEW
« no previous file with comments | « Source/core/css/MediaQueryListListener.cpp ('k') | Source/core/css/MediaQueryMatcher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698