Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 396273004: clean up coding style at ash folder. (Closed)

Created:
6 years, 5 months ago by rucifer1217
Modified:
6 years, 5 months ago
Reviewers:
James Cook, Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clean up coding style at ash folder. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284594

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M ash/ash_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/cancel_mode.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/debug.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/debug.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/screen_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
rucifer1217
please review this code.
6 years, 5 months ago (2014-07-21 17:02:30 UTC) #1
Daniel Erat
lgtm with a comment https://codereview.chromium.org/396273004/diff/1/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/396273004/diff/1/ash/root_window_controller_unittest.cc#newcode613 ash/root_window_controller_unittest.cc:613: class VirtualKeyboardRootWindowControllerTest : public RootWindowControllerTest ...
6 years, 5 months ago (2014-07-21 17:15:10 UTC) #2
James Cook
LGTM with a comment https://codereview.chromium.org/396273004/diff/1/ash/debug.cc File ash/debug.cc (right): https://codereview.chromium.org/396273004/diff/1/ash/debug.cc#newcode60 ash/debug.cc:60: } // namespace bug "bug" ...
6 years, 5 months ago (2014-07-21 17:28:19 UTC) #3
rucifer1217
https://codereview.chromium.org/396273004/diff/1/ash/debug.cc File ash/debug.cc (right): https://codereview.chromium.org/396273004/diff/1/ash/debug.cc#newcode60 ash/debug.cc:60: } // namespace bug On 2014/07/21 17:28:19, James Cook ...
6 years, 5 months ago (2014-07-21 21:54:27 UTC) #4
Daniel Erat
https://codereview.chromium.org/396273004/diff/20001/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/396273004/diff/20001/ash/root_window_controller_unittest.cc#newcode614 ash/root_window_controller_unittest.cc:614: : public RootWindowControllerTest { indent wrapped lines four spaces ...
6 years, 5 months ago (2014-07-21 21:56:37 UTC) #5
rucifer1217
https://codereview.chromium.org/396273004/diff/20001/ash/root_window_controller_unittest.cc File ash/root_window_controller_unittest.cc (right): https://codereview.chromium.org/396273004/diff/20001/ash/root_window_controller_unittest.cc#newcode614 ash/root_window_controller_unittest.cc:614: : public RootWindowControllerTest { On 2014/07/21 21:56:36, Daniel Erat ...
6 years, 5 months ago (2014-07-21 22:54:01 UTC) #6
Daniel Erat
lgtm
6 years, 5 months ago (2014-07-21 22:55:04 UTC) #7
James Cook
lgtm
6 years, 5 months ago (2014-07-21 22:56:32 UTC) #8
rucifer1217
The CQ bit was checked by rucifer1217@gmail.com
6 years, 5 months ago (2014-07-21 22:57:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rucifer1217@gmail.com/396273004/40001
6 years, 5 months ago (2014-07-21 22:58:16 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 02:16:21 UTC) #11
Message was sent while issue was closed.
Change committed as 284594

Powered by Google App Engine
This is Rietveld 408576698