Switch the input code to use AudioBlockFifo

Switch the input code to use AudioBlockFifo.

It saves two memcpy and quite some intermedia AudioBus code.

Also, this CL corrects a mistake in https://codereview.chromium.org/389623002/ by using FromInterleavedPartial() instead of FromInterleaved().

BUG=393199
TEST=bots and webrtc loopback test: https://apprtc.appspot.com

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284477

[no longer working on chromium, 2014-07-18 11:58:53]

Dale, could you please review this CL? Thanks.

[DaleCurtis, 2014-07-18 18:21:54]

Wrong Dale :)

lgtm % nits.

https://codereview.chromium.org/396263004/diff/20001/media/audio/mac/audio_lo...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/396263004/diff/20001/media/audio/mac/audio_lo...
media/audio/mac/audio_low_latency_input_mac.cc:50: fifo_(new
AudioBlockFifo(input_params.channels(), number_of_frames_,
No need for dynamic allocation.

https://codereview.chromium.org/396263004/diff/20001/media/audio/mac/audio_lo...
media/audio/mac/audio_low_latency_input_mac.cc:506:
CHECK_EQ(audio_bus->frames(), static_cast<int>(number_of_frames_));
DCHECK? shouldn't ever be wrong since you're no longer reallocating.

https://codereview.chromium.org/396263004/diff/20001/media/audio/pulse/pulse_...
File media/audio/pulse/pulse_input.cc (right):

https://codereview.chromium.org/396263004/diff/20001/media/audio/pulse/pulse_...
media/audio/pulse/pulse_input.cc:59: fifo_.reset(new
AudioBlockFifo(params_.channels(),
Avoid dynamic allocation during construction?

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
File media/base/audio_block_fifo.cc (right):

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
media/base/audio_block_fifo.cc:47:
current_block->FromInterleavedPartial(source_ptr, write_pos_, push_frames,
Whoops.  Is this style clang-format approved?

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
File media/base/audio_block_fifo.h (right):

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
media/base/audio_block_fifo.h:44: return available_blocks_ * block_frames_ +
write_pos_;
Needs to be non-hacker style since it's doing math.

[no longer working on chromium, 2014-07-21 15:13:30]

Thanks Mr Curtis :)

https://codereview.chromium.org/396263004/diff/20001/media/audio/mac/audio_lo...
File media/audio/mac/audio_low_latency_input_mac.cc (right):

https://codereview.chromium.org/396263004/diff/20001/media/audio/mac/audio_lo...
media/audio/mac/audio_low_latency_input_mac.cc:50: fifo_(new
AudioBlockFifo(input_params.channels(), number_of_frames_,
On 2014/07/18 18:21:54, DaleCurtis wrote:
> No need for dynamic allocation.

Done.

https://codereview.chromium.org/396263004/diff/20001/media/audio/mac/audio_lo...
media/audio/mac/audio_low_latency_input_mac.cc:506:
CHECK_EQ(audio_bus->frames(), static_cast<int>(number_of_frames_));
On 2014/07/18 18:21:54, DaleCurtis wrote:
> DCHECK? shouldn't ever be wrong since you're no longer reallocating.

Done. DCHECK is helping to make sure we deliver what the clients request.

https://codereview.chromium.org/396263004/diff/20001/media/audio/pulse/pulse_...
File media/audio/pulse/pulse_input.cc (right):

https://codereview.chromium.org/396263004/diff/20001/media/audio/pulse/pulse_...
media/audio/pulse/pulse_input.cc:59: fifo_.reset(new
AudioBlockFifo(params_.channels(),
On 2014/07/18 18:21:54, DaleCurtis wrote:
> Avoid dynamic allocation during construction?

Done.

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
File media/base/audio_block_fifo.cc (right):

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
media/base/audio_block_fifo.cc:47:
current_block->FromInterleavedPartial(source_ptr, write_pos_, push_frames,
On 2014/07/18 18:21:54, DaleCurtis wrote:
> Whoops.  Is this style clang-format approved?

Fixed.

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
File media/base/audio_block_fifo.h (right):

https://codereview.chromium.org/396263004/diff/20001/media/base/audio_block_f...
media/base/audio_block_fifo.h:44: return available_blocks_ * block_frames_ +
write_pos_;
On 2014/07/18 18:21:54, DaleCurtis wrote:
> Needs to be non-hacker style since it's doing math.

Thanks, I forgot it again.

Done.

[no longer working on chromium, 2014-07-21 15:13:35]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-07-21 15:14:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/396263004/60001

[commit-bot: I haz the power, 2014-07-21 17:10:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-21 19:36:57]

Change committed as 284477