Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: LayoutTests/css3/flexbox/flex-property-parsing.html

Issue 396263003: flex shorthand incorrectly accepting 1 0% 1 (i.e. flex-basis in the middle) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/flex-property-parsing-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/css3/flexbox/flex-property-parsing.html
diff --git a/LayoutTests/css3/flexbox/flex-property-parsing.html b/LayoutTests/css3/flexbox/flex-property-parsing.html
index d4e716e49fedfd85f98daf2447bd5fcec9e926ee..05ab071c2a846f26b1308b0292f873ea7c6c834d 100644
--- a/LayoutTests/css3/flexbox/flex-property-parsing.html
+++ b/LayoutTests/css3/flexbox/flex-property-parsing.html
@@ -137,9 +137,9 @@ flexitem.style.webkitFlex = '1.75 2 3px';
shouldBeEqualToString('flexitem.style.webkitFlex', '1.75 2 3px');
shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.75 2 3px');
-flexitem.style.webkitFlex = '1 3px 2';
-shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 3px');
-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 3px');
+flexitem.style.webkitFlex = '1 3px 2'; // Invalid, return previous value.
+shouldBeEqualToString('flexitem.style.webkitFlex', '1.75 2 3px');
+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.75 2 3px');
flexitem.style.webkitFlex = '3px 1 2';
shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 3px');
@@ -161,9 +161,9 @@ flexitem.style.webkitFlex = '0px 0';
shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px');
shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px');
-flexitem.style.webkitFlex = '0 0px 0';
-shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 0px');
-shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 0px');
+flexitem.style.webkitFlex = '0 0px 0'; // Invalid, return previous value.
+shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px');
+shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px');
flexitem.style.webkitFlex = 'none';
flexitem.style.webkitFlex = '1 2 3'; // Invalid, return previous value.
« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/flex-property-parsing-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698