Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/css3/flexbox/flex-property-parsing.html

Issue 396263003: flex shorthand incorrectly accepting 1 0% 1 (i.e. flex-basis in the middle) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/flex-property-parsing-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src="../../resources/js-test.js"></script> 4 <script src="../../resources/js-test.js"></script>
5 </head> 5 </head>
6 <body> 6 <body>
7 <div id="flexbox"> 7 <div id="flexbox">
8 <div id="flexitem"></div> 8 <div id="flexitem"></div>
9 </div> 9 </div>
10 <script> 10 <script>
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 0px'); 130 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 0px');
131 131
132 flexitem.style.webkitFlex = '1 2 auto'; 132 flexitem.style.webkitFlex = '1 2 auto';
133 shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 auto'); 133 shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 auto');
134 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 auto'); 134 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 auto');
135 135
136 flexitem.style.webkitFlex = '1.75 2 3px'; 136 flexitem.style.webkitFlex = '1.75 2 3px';
137 shouldBeEqualToString('flexitem.style.webkitFlex', '1.75 2 3px'); 137 shouldBeEqualToString('flexitem.style.webkitFlex', '1.75 2 3px');
138 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.75 2 3px'); 138 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.75 2 3px');
139 139
140 flexitem.style.webkitFlex = '1 3px 2'; 140 flexitem.style.webkitFlex = '1 3px 2'; // Invalid, return previous value.
141 shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 3px'); 141 shouldBeEqualToString('flexitem.style.webkitFlex', '1.75 2 3px');
142 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 3px'); 142 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1.75 2 3px');
143 143
144 flexitem.style.webkitFlex = '3px 1 2'; 144 flexitem.style.webkitFlex = '3px 1 2';
145 shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 3px'); 145 shouldBeEqualToString('flexitem.style.webkitFlex', '1 2 3px');
146 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 3px'); 146 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '1 2 3px');
147 147
148 flexitem.style.webkitFlex = 'auto 0 0'; 148 flexitem.style.webkitFlex = 'auto 0 0';
149 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto'); 149 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto');
150 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto'); 150 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto');
151 151
152 flexitem.style.webkitFlex = 'auto 0'; 152 flexitem.style.webkitFlex = 'auto 0';
153 shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 auto'); 153 shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 auto');
154 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 auto'); 154 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 auto');
155 155
156 flexitem.style.webkitFlex = 'auto 3'; 156 flexitem.style.webkitFlex = 'auto 3';
157 shouldBeEqualToString('flexitem.style.webkitFlex', '3 1 auto'); 157 shouldBeEqualToString('flexitem.style.webkitFlex', '3 1 auto');
158 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '3 1 auto'); 158 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '3 1 auto');
159 159
160 flexitem.style.webkitFlex = '0px 0'; 160 flexitem.style.webkitFlex = '0px 0';
161 shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px'); 161 shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px');
162 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px'); 162 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px');
163 163
164 flexitem.style.webkitFlex = '0 0px 0'; 164 flexitem.style.webkitFlex = '0 0px 0'; // Invalid, return previous value.
165 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 0px'); 165 shouldBeEqualToString('flexitem.style.webkitFlex', '0 1 0px');
166 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 0px'); 166 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 0px');
167 167
168 flexitem.style.webkitFlex = 'none'; 168 flexitem.style.webkitFlex = 'none';
169 flexitem.style.webkitFlex = '1 2 3'; // Invalid, return previous value. 169 flexitem.style.webkitFlex = '1 2 3'; // Invalid, return previous value.
170 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto'); 170 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto');
171 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto'); 171 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto');
172 172
173 flexitem.style.webkitFlex = '0 2 3'; // Invalid, return previous value. 173 flexitem.style.webkitFlex = '0 2 3'; // Invalid, return previous value.
174 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto'); 174 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto');
175 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto'); 175 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto');
176 176
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 shouldBeEqualToString('flexitem.style.webkitFlex', 'initial'); 226 shouldBeEqualToString('flexitem.style.webkitFlex', 'initial');
227 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 auto'); 227 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 1 auto');
228 228
229 flexitem.style.webkitFlex = 'none'; 229 flexitem.style.webkitFlex = 'none';
230 // FIXME: This test case is failing. https://bugs.webkit.org/show_bug.cgi?id=900 20 230 // FIXME: This test case is failing. https://bugs.webkit.org/show_bug.cgi?id=900 20
231 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto'); 231 shouldBeEqualToString('flexitem.style.webkitFlex', '0 0 auto');
232 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto'); 232 shouldBeEqualToString('getComputedStyle(flexitem).webkitFlex', '0 0 auto');
233 </script> 233 </script>
234 </body> 234 </body>
235 </html> 235 </html>
OLDNEW
« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/flex-property-parsing-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698