LayoutTests/css3/flexbox/flex-shorthand-flex-basis-middle.html - Issue 396263003: flex shorthand incorrectly accepting 1 0% 1 (i.e. flex-basis in the middle)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/flexbox/flex-shorthand-flex-basis-middle.html

Issue 396263003: flex shorthand incorrectly accepting 1 0% 1 (i.e. flex-basis in the middle) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: WIP Patch 2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/css3/flexbox/flex-property-parsing-expected.txt ('k') | LayoutTests/css3/flexbox/flex-shorthand-flex-basis-middle-expected.txt » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <link href="resources/flexbox.css" rel="stylesheet">

	4 <style>

	5 .flexbox {

	6 background: green;
	tony 2014/07/16 17:12:38 Nit: Style in our test html files isn't that impor Nit: Style in our test html files isn't that important, but I don't think we ever use 8 space indents. harpreet.sk 2014/07/17 08:03:25 Done. Show quoted text On 2014/07/16 17:12:38, tony wrote: > Nit: Style in our test html files isn't that important, but I don't think we > ever use 8 space indents. Done.
	7 position: relative;

	8 padding: 10px;

	9 border: 2px solid red;

	10 }

	11

	12 .flexbox > div {

	13 background: yellow;

	14 flex: 1 0% 1;

	15 border: 1px solid black;

	16 width: 50px;

	17 }

	18 </style>

	19 <script src="../../resources/check-layout.js"></script>

	20 <body onload="checkLayout('.flexbox')">

	21 <div class="flexbox" style="width: 500px; height:100px">

	22 <div data-expected-width="52"></div>

	23 <div data-expected-width="52"></div>

	24 <div data-expected-width="52"></div>

	25 </div>

	26 </body>

	27 </html>

OLD	NEW