Issue 396243006: Mojo: Mojom: Remove redundant line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396243006: Mojo: Mojom: Remove redundant line. (Closed)

Created:
6 years, 5 months ago by viettrungluu

Modified:
6 years, 5 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mojo: Mojom: Remove redundant line. Per review comment from https://codereview.chromium.org/398553002/. Note that I'm keeping the |pass| and deleting the redundant assignment (so now the |pass| is required). The alternative would be to nest the other |if|s inside an |if ... is not None|, but I find that harder to read. TBR=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283605

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	mojo/public/tools/bindings/pylib/mojom/parse/ast.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/396243006/1

6 years, 5 months ago (2014-07-16 19:28:56 UTC) #3

viettrungluu

6 years, 5 months ago (2014-07-17 01:13:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r283605 (presubmit successful).

Expand Messages | Collapse Messages