Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 396233002: Removed git cl push command (Closed)

Created:
6 years, 5 months ago by pgervais
Modified:
6 years, 5 months ago
Reviewers:
agable, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master
Project:
tools
Visibility:
Public.

Description

Removed git cl push command The user message says the subcommand will stop working on July 1. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=285586

Patch Set 1 #

Patch Set 2 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M git_cl.py View 3 chunks +0 lines, -23 lines 0 comments Download
M tests/push-basic.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pgervais
Some cleanup.
6 years, 5 months ago (2014-07-16 12:09:58 UTC) #1
M-A Ruel
lgtm
6 years, 5 months ago (2014-07-16 12:11:01 UTC) #2
pgervais
The CQ bit was checked by pgervais@chromium.org
6 years, 5 months ago (2014-07-21 21:27:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgervais@chromium.org/396233002/1
6 years, 5 months ago (2014-07-21 21:28:25 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 21:30:18 UTC) #5
commit-bot: I haz the power
Presubmit check for 396233002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 5 months ago (2014-07-21 21:30:19 UTC) #6
pgervais
The CQ bit was checked by pgervais@chromium.org
6 years, 5 months ago (2014-07-25 14:27:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgervais@chromium.org/396233002/20001
6 years, 5 months ago (2014-07-25 14:28:28 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 14:30:35 UTC) #9
Message was sent while issue was closed.
Change committed as 285586

Powered by Google App Engine
This is Rietveld 408576698