Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 396213010: [DevTools] Scale context menu position by pageZoomFactor. (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Scale context menu position by pageZoomFactor. BUG=394669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look please.
6 years, 5 months ago (2014-07-17 12:33:50 UTC) #1
pfeldman
lgtm
6 years, 5 months ago (2014-07-18 16:08:55 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-18 18:11:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/396213010/1
6 years, 5 months ago (2014-07-18 18:12:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-18 19:16:35 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 19:30:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/35779)
6 years, 5 months ago (2014-07-18 19:30:08 UTC) #7
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 5 months ago (2014-07-18 19:50:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/396213010/1
6 years, 5 months ago (2014-07-18 19:51:32 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 19:53:05 UTC) #10
Message was sent while issue was closed.
Change committed as 178478

Powered by Google App Engine
This is Rietveld 408576698