Issue 396213009: Removes CastBrowserMainParts::GetInstance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 396213009: Removes CastBrowserMainParts::GetInstance. (Closed)

Created:
6 years, 5 months ago by gunsch

Modified:
6 years, 5 months ago

Reviewers:
lcwu1, jam

CC:
chromium-reviews, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Removes CastBrowserMainParts::GetInstance. This is currently unused and not necessary in future Chromecast code. R=lcwu@chromium.org,jam@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284011

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -16 lines)			Patch
	M	chromecast/shell/browser/cast_browser_main_parts.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chromecast/shell/browser/cast_browser_main_parts.cc	View	1	3 chunks	+0 lines, -13 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/396213009/20001

6 years, 5 months ago (2014-07-17 22:51:52 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-18 04:03:37 UTC) #6

Message was sent while issue was closed.

Change committed as 284011