Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: runtime/vm/coverage.cc

Issue 396213005: Fix PcDescriptor iteratot to never return a pointer to a memory location since the data can move wi… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_descriptors_test.cc ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/coverage.cc
===================================================================
--- runtime/vm/coverage.cc (revision 38336)
+++ runtime/vm/coverage.cc (working copy)
@@ -95,11 +95,11 @@
RawPcDescriptors::kIcCall | RawPcDescriptors::kUnoptStaticCall);
while (iter.HasNext()) {
HANDLESCOPE(isolate);
- const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();
- intptr_t deopt_id = rec.deopt_id();
- const ICData* ic_data = (*ic_data_array)[deopt_id];
+ RawPcDescriptors::PcDescriptorRec rec;
+ iter.NextRec(&rec);
+ const ICData* ic_data = (*ic_data_array)[rec.deopt_id()];
if (!ic_data->IsNull()) {
- intptr_t token_pos = rec.token_pos();
+ const intptr_t token_pos = rec.token_pos();
// Filter out descriptors that do not map to tokens in the source code.
if ((token_pos < begin_pos) || (token_pos > end_pos)) {
continue;
« no previous file with comments | « runtime/vm/code_descriptors_test.cc ('k') | runtime/vm/debugger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698