Fix PcDescriptor iteratot to never return a pointer to a memory location since the data can move wi…

runtime/vm/coverage.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/coverage.h"
 
 #include "include/dart_api.h"
 
 #include "vm/compiler.h"
 #include "vm/isolate.h"
@@ skipping 77 matching lines @@
 
   const intptr_t begin_pos = function.token_pos();
   const intptr_t end_pos = function.end_token_pos();
   intptr_t last_line = -1;
   intptr_t last_count = 0;
   // Only IC based calls have counting.
   PcDescriptors::Iterator iter(descriptors,
       RawPcDescriptors::kIcCall | RawPcDescriptors::kUnoptStaticCall);
   while (iter.HasNext()) {
     HANDLESCOPE(isolate);
-    const RawPcDescriptors::PcDescriptorRec& rec = iter.Next();
-    intptr_t deopt_id = rec.deopt_id();
-    const ICData* ic_data = (*ic_data_array)[deopt_id];
+    RawPcDescriptors::PcDescriptorRec rec;
+    iter.NextRec(&rec);
+    const ICData* ic_data = (*ic_data_array)[rec.deopt_id()];
     if (!ic_data->IsNull()) {
-      intptr_t token_pos = rec.token_pos();
+      const intptr_t token_pos = rec.token_pos();
       // Filter out descriptors that do not map to tokens in the source code.
       if ((token_pos < begin_pos) || (token_pos > end_pos)) {
         continue;
       }
       intptr_t line = pos_to_line[token_pos];
 #if defined(DEBUG)
       const Script& script = Script::Handle(function.script());
       intptr_t test_line = -1;
       script.GetTokenLocation(token_pos, &test_line, NULL);
       ASSERT(test_line == line);
@@ skipping 170 matching lines @@
         cls = it.GetNextClass();
         ASSERT(!cls.IsNull());
         PrintClass(lib, cls, jsarr, filter);
       }
     }
   }
 }
 
 
 }  // namespace dart