Converts RTCOfferOptions to constriants in the glue code for createOffer.

Converts RTCOfferOptions to constriants in the glue code for createOffer.


TBR=pfeldman@chromium.org for content/shell/renderer/test_runner

BUG=https://code.google.com/p/webrtc/issues/detail?id=3282

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285659

[jiayl, 2014-07-17 16:56:22]

PTAL.

mallinath: rtc_peer_connection_handler.*, peer_connection_dependency_factory.*

vrk: all */media/*, mostly webrtc-internals related

inferno: content/common/media/peer_connection_tracker_messages.h

pfeldman: content/shell/renderer/*

Thanks!

[Tom Sepez, 2014-07-17 23:23:07]

Messages LGTM.

[Mallinath (Gone from Chromium), 2014-07-18 00:12:27]

On 2014/07/17 23:23:07, Tom Sepez wrote:
> Messages LGTM.

lgtm rtc_peer_connection_handler.*, peer_connection_dependency_factory.*

[jiayl, 2014-07-18 21:03:34]

Ping vrk and pfeldman.

[vrk (LEFT CHROMIUM), 2014-07-23 01:13:05]

A few questions just because I'm not too familiar with the work here prior to
this CL.

https://codereview.chromium.org/396193005/diff/20001/content/browser/media/we...
File content/browser/media/webrtc_internals.cc (right):

https://codereview.chromium.org/396193005/diff/20001/content/browser/media/we...
content/browser/media/webrtc_internals.cc:70: const string& rtc_configuration,
It looks like this also modifies updates webrtc-internals to use the new
PeerConnection constructor, with RTCConfiguration replacing the servers
parameter. Is this related to the createOffer/RTCOfferOptions change?

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/r...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/r...
content/renderer/media/rtc_peer_connection_handler.cc:419: void
RTCPeerConnectionHandler::ConvertOfferOptionsToConstraints(
Why convert the OfferOptions to Constraints instead of the other way around?
Isn't OfferOptions the new way, and Constraints the old way that will eventually
get deleted?

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:378: const
webrtc::PeerConnectionInterface::RTCConfiguration& config,
Is the old PeerConnection constructor still supported?

[jiayl, 2014-07-23 16:11:13]

Thanks!

https://codereview.chromium.org/396193005/diff/20001/content/browser/media/we...
File content/browser/media/webrtc_internals.cc (right):

https://codereview.chromium.org/396193005/diff/20001/content/browser/media/we...
content/browser/media/webrtc_internals.cc:70: const string& rtc_configuration,
On 2014/07/23 01:13:05, Victoria Kirst wrote:
> It looks like this also modifies updates webrtc-internals to use the new
> PeerConnection constructor, with RTCConfiguration replacing the servers
> parameter. Is this related to the createOffer/RTCOfferOptions change?

It is, since this CL also add RTCTransportType, which will not be reported on
webrtc-internals if we don't change |servers| to |rtc_configuration|.

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/r...
File content/renderer/media/rtc_peer_connection_handler.cc (right):

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/r...
content/renderer/media/rtc_peer_connection_handler.cc:419: void
RTCPeerConnectionHandler::ConvertOfferOptionsToConstraints(
On 2014/07/23 01:13:05, Victoria Kirst wrote:
> Why convert the OfferOptions to Constraints instead of the other way around?
> Isn't OfferOptions the new way, and Constraints the old way that will
eventually
> get deleted?

Libjingle does not have the interface to receive OfferOptions yet. It'll be done
in a follow up CL on the libjingle side.

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/w...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/396193005/diff/20001/content/renderer/media/w...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:378: const
webrtc::PeerConnectionInterface::RTCConfiguration& config,
On 2014/07/23 01:13:05, Victoria Kirst wrote:
> Is the old PeerConnection constructor still supported?

No, RTCConfiguration contains IceServers, there is no need to have the old
method.
See
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjin...

[vrk (LEFT CHROMIUM), 2014-07-24 22:53:59]

lgtm

[jiayl, 2014-07-24 23:07:14]

abarth@,

could you take a look at content/shell/renderer/test_runner?

[jiayl, 2014-07-25 18:44:55]

The CQ bit was checked by jiayl@chromium.org

[commit-bot: I haz the power, 2014-07-25 18:46:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jiayl@chromium.org/396193005/60001

[commit-bot: I haz the power, 2014-07-25 20:24:59]

Change committed as 285659