Adjust null object check

core/src/fpdfdoc/doc_ap.cpp

Index: core/src/fpdfdoc/doc_ap.cpp
diff --git a/core/src/fpdfdoc/doc_ap.cpp b/core/src/fpdfdoc/doc_ap.cpp
index 6a8ab374d21e7150339d2f4258977eef8b25c6d6..67685a26d05341fc7db2c0e0ba64fe1eea2dd740 100644
--- a/core/src/fpdfdoc/doc_ap.cpp
+++ b/core/src/fpdfdoc/doc_ap.cpp
@@ -253,7 +253,11 @@ static FX_BOOL GenerateWidgetAP(CPDF_Document* pDoc, CPDF_Dictionary* pAnnotDict
     if (!pFormDict) {
         return FALSE;
     }
-    CFX_ByteString DA = FPDF_GetFieldAttr(pAnnotDict, "DA") ? FPDF_GetFieldAttr(pAnnotDict, "DA")->GetString() : CFX_ByteString();
+    CFX_ByteString DA;
+    CPDF_Object* pDAObj = FPDF_GetFieldAttr(pAnnotDict, "DA");
+    if (pDAObj) {

[Nico, 2014/07/21 05:07:53]

Since pDAObj is only used in the if, you can write this as

  if (CPDF_Object* pDAObj = FPDF_GetFieldAttr(pAnnotDict, "DA")) {
    DA = pDAObj->GetString();
  }

if you want. It's a bit shorter.

[Bo Xu, 2014/07/21 16:40:44]

Agree!

+        DA = pDAObj->GetString();
+    }
     if (DA.IsEmpty()) {
         DA = pFormDict->GetString("DA");
     }