Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 396173003: Adjust null object check (Closed)

Created:
6 years, 5 months ago by Bo Xu
Modified:
6 years, 5 months ago
Reviewers:
Nico
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Adjust null object check BUG=None R=thakis@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/22b31e0

Patch Set 1 #

Total comments: 5

Patch Set 2 : respond to comments #

Total comments: 6

Patch Set 3 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M core/src/fpdfdoc/doc_ap.cpp View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bo Xu
Some previous check are not optimal and clear, so changes are made here.
6 years, 5 months ago (2014-07-21 04:05:09 UTC) #1
Nico
I agree this is much clearer :-) https://codereview.chromium.org/396173003/diff/1/core/src/fpdfdoc/doc_ap.cpp File core/src/fpdfdoc/doc_ap.cpp (right): https://codereview.chromium.org/396173003/diff/1/core/src/fpdfdoc/doc_ap.cpp#newcode258 core/src/fpdfdoc/doc_ap.cpp:258: if (pDAObj) ...
6 years, 5 months ago (2014-07-21 05:07:53 UTC) #2
Bo Xu
https://codereview.chromium.org/396173003/diff/1/core/src/fpdfdoc/doc_ap.cpp File core/src/fpdfdoc/doc_ap.cpp (right): https://codereview.chromium.org/396173003/diff/1/core/src/fpdfdoc/doc_ap.cpp#newcode258 core/src/fpdfdoc/doc_ap.cpp:258: if (pDAObj) { On 2014/07/21 05:07:53, Nico (away) wrote: ...
6 years, 5 months ago (2014-07-21 16:40:45 UTC) #3
Nico
lgtm https://codereview.chromium.org/396173003/diff/20001/core/src/fpdfdoc/doc_ap.cpp File core/src/fpdfdoc/doc_ap.cpp (right): https://codereview.chromium.org/396173003/diff/20001/core/src/fpdfdoc/doc_ap.cpp#newcode257 core/src/fpdfdoc/doc_ap.cpp:257: if (CPDF_Object* pDAObj = FPDF_GetFieldAttr(pAnnotDict, "DA")){ nit: add ...
6 years, 5 months ago (2014-07-21 16:48:12 UTC) #4
Bo Xu
https://codereview.chromium.org/396173003/diff/20001/core/src/fpdfdoc/doc_ap.cpp File core/src/fpdfdoc/doc_ap.cpp (right): https://codereview.chromium.org/396173003/diff/20001/core/src/fpdfdoc/doc_ap.cpp#newcode257 core/src/fpdfdoc/doc_ap.cpp:257: if (CPDF_Object* pDAObj = FPDF_GetFieldAttr(pAnnotDict, "DA")){ On 2014/07/21 16:48:12, ...
6 years, 5 months ago (2014-07-21 17:01:30 UTC) #5
Bo Xu
6 years, 5 months ago (2014-07-21 17:02:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r22b31e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698